Fix file upload #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit - c37ee9a - broke regular file upload in most cases. File upload works fine for really small files (around ~50KB from what I noticed), but instantly breaks if the file is a bit larger than that. It looks like the issue is related to the order in which the data is handled in the POST request (as discussed here - #1 (comment)) - in some cases, the "field" event is not triggered, leaving the stream unconsumed (which leaves the client hanging).
The suggested branch includes some formatting changes (second commit) - you can omit them if you want.